pvary commented on code in PR #14270:
URL: https://github.com/apache/iceberg/pull/14270#discussion_r2413746380
##########
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java:
##########
@@ -122,17 +123,21 @@ public Expression bind(StructType struct, boolean
caseSensitive) {
return bindLiteralOperation(bound);
}
- private Expression bindUnaryOperation(BoundTerm<T> boundTerm) {
+ private Expression bindUnaryOperation(StructType struct, BoundTerm<T>
boundTerm) {
+ boolean allFieldsAreRequired =
+ TypeUtil.findParents(struct.asSchema(),
boundTerm.ref().fieldId()).stream()
Review Comment:
How often do we evaluate these expressions? For every manifest entry?
For a wide schema, what is the additional cost of calculating the parents
every time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
