liurenjie1024 commented on code in PR #1730:
URL: https://github.com/apache/iceberg-rust/pull/1730#discussion_r2416250690
##########
crates/iceberg/src/spec/partition.rs:
##########
@@ -155,7 +155,9 @@ impl PartitionSpec {
true
}
- pub(crate) fn partition_to_path(&self, data: &Struct, schema: SchemaRef)
-> String {
+ /// Returns partition path string containing partition type and partition
+ /// value as key-value pairs.
+ pub fn partition_to_path(&self, data: &Struct, schema: SchemaRef) ->
String {
Review Comment:
Why we need to make this pub? It's used internally by `LocationGenerator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
