dongxiao1198 commented on code in PR #216:
URL: https://github.com/apache/iceberg-cpp/pull/216#discussion_r2422376802
##########
src/iceberg/test/manifest_reader_writer_test.cc:
##########
@@ -230,4 +281,21 @@ TEST_F(ManifestReaderV2Test, MetadataInheritanceTest) {
TestManifestReadingWithManifestFile(manifest_file, expected_entries);
}
+TEST_F(ManifestReaderV2Test, WriteNonPartitionedTest) {
+ auto expected_entries = PrepareNonPartitionedTestData();
+ auto write_manifest_path = CreateNewTempFilePath();
+ TestWriteManifest(679879563479918846LL, write_manifest_path, nullptr,
expected_entries);
+ TestManifestReadingByPath(write_manifest_path, expected_entries);
+}
+
+TEST_F(ManifestReaderV2Test, WriteInheritancePartitionedTest) {
+ auto expected_entries = PrepareMetadataInheritanceTestData();
+ auto write_manifest_path = CreateNewTempFilePath();
+ TestWriteManifest(679879563479918846LL, write_manifest_path, nullptr,
expected_entries);
+ for (auto& entry : expected_entries) {
+ entry.data_file->partition_spec_id = PartitionSpec::kInitialSpecId;
Review Comment:
Now we have to ManifestReader::Make(), the one which use manifest file path
to create write will not set the partition_spec_id to it, I may use the other
creator instead to avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
