stevenzwu commented on code in PR #14271:
URL: https://github.com/apache/iceberg/pull/14271#discussion_r2415121310
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -37,9 +38,10 @@
import org.apache.iceberg.io.FileWriterFactory;
import org.apache.iceberg.orc.ORC;
import org.apache.iceberg.parquet.Parquet;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
/** A base writer factory to be extended by query engine integrations. */
-public abstract class BaseFileWriterFactory<T> implements FileWriterFactory<T>
{
+public abstract class BaseFileWriterFactory<T> implements
FileWriterFactory<T>, Serializable {
Review Comment:
Checked the child classes. `SparkFileWriterFactory` is probably ok, as the
`Table` object was extracted from a broadcast variable for `SerializableTable`.
But `GenericFileWriterFactory` ma be constructed with a regular and may not be
serializable.
Since `FlinkFileWriterFactory` is already marked as serializable. maybe we
don't need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
