Fokko commented on code in PR #2557:
URL: https://github.com/apache/iceberg-python/pull/2557#discussion_r2401848933
##########
pyiceberg/expressions/__init__.py:
##########
@@ -565,8 +573,11 @@ def as_bound(self) -> Type[BoundNotNaN[L]]:
return BoundNotNaN[L]
-class SetPredicate(UnboundPredicate[L], ABC):
- literals: Set[Literal[L]]
+class SetPredicate(UnboundPredicate[L], IcebergBaseModel, ABC):
Review Comment:
The class and init should be:
```python
class SetPredicate(IcebergBaseModel, UnboundPredicate[L], ABC):
model_config = ConfigDict(arbitrary_types_allowed=True)
type: TypingLiteral["in", "not-in"] = Field(default="in")
literals: Set[Literal[L]] = Field(alias="items")
def __init__(self, term: Union[str, UnboundTerm[Any]], literals:
Union[Iterable[L], Iterable[Literal[L]]]):
super().__init__(term=_to_unbound_term(term),
items=_to_literal_set(literals))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
