Fokko commented on code in PR #2557:
URL: https://github.com/apache/iceberg-python/pull/2557#discussion_r2397349860
##########
pyiceberg/expressions/__init__.py:
##########
@@ -559,12 +561,19 @@ def as_bound(self) -> Type[BoundNotNaN[L]]:
return BoundNotNaN[L]
-class SetPredicate(UnboundPredicate[L], ABC):
- literals: Set[Literal[L]]
+class SetPredicate(UnboundPredicate[L], IcebergBaseModel, ABC):
+ type: str = Field(default="in", alias="type")
+ term: str
+ value: list[Any]
Review Comment:
I'm sorry, I made a mistake in the issue, according to the spec:
https://github.com/apache/iceberg/blob/6fd5e29f3ef4b0fe62ab2805861bfcf3973f79c8/open-api/rest-catalog-open-api.yaml#L2282
It should be:
```suggestion
literals: Set[Literal[L]] = Field(alias="items")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
