RussellSpitzer commented on code in PR #14000:
URL: https://github.com/apache/iceberg/pull/14000#discussion_r2394711965
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -327,7 +327,7 @@ public long currentRows() {
}
private void openCurrent() {
- if (partitionKey == null) {
+ if (spec.isUnpartitioned() || partitionKey == null) {
Review Comment:
Those would both be new behaviors, either breaking on unpartitioned or
changing the layout .
I'm not sure either is really justified. If I had to pick I would just throw
an exception on unpartitioned. Since that would be a breaking change, I would
probably just do nothing. Users with unpartitioned data to can still use the u
partitioned writer if the directory layout is important for them. I said this
above, but we shouldn’t need a custom implementation of this class to test
whether or not an internal behavior works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
