danielcweeks commented on code in PR #14196:
URL: https://github.com/apache/iceberg/pull/14196#discussion_r2392320467
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1966,6 +2021,17 @@ components:
"GET /v1/{prefix}/namespaces/{namespace}/tables/{table}",
"GET /v1/{prefix}/namespaces/{namespace}/views/{view}"
]
+ idempotencyKeyLifetime:
+ type: string
+ format: duration
+ description: >
+ Client reuse window for an Idempotency-Key (ISO-8601 duration,
e.g., PT30M, PT24H).
+ Interpreted as the maximum time from the first submission using a
key to the last retry
+ during which a client may reuse that key. Servers MUST accept
replays for at least this
Review Comment:
> Servers MUST accept replays for at least
nit: I don't think we should say `MUST` here. Servers may reject a request
for any number of reasons and I don't think the spec should try an force
behavior here. This would be better as a `SHOULD`.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1966,6 +2021,17 @@ components:
"GET /v1/{prefix}/namespaces/{namespace}/tables/{table}",
"GET /v1/{prefix}/namespaces/{namespace}/views/{view}"
]
+ idempotencyKeyLifetime:
+ type: string
+ format: duration
+ description: >
+ Client reuse window for an Idempotency-Key (ISO-8601 duration,
e.g., PT30M, PT24H).
+ Interpreted as the maximum time from the first submission using a
key to the last retry
+ during which a client may reuse that key. Servers MUST accept
replays for at least this
Review Comment:
> Servers MUST accept replays for at least
I don't think we should say `MUST` here. Servers may reject a request for
any number of reasons and I don't think the spec should try an force behavior
here. This would be better as a `SHOULD`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
