tomtongue commented on code in PR #14212:
URL: https://github.com/apache/iceberg/pull/14212#discussion_r2391423596
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -2113,6 +2113,26 @@ public void createViewWithCustomMetadataLocation() {
""));
}
+ @TestTemplate
+ public void createViewWithCustomMetadataLocationWithLocation() {
+ String viewName = viewName("v");
+ String customMetadataLocation =
+ Paths.get(temp.toUri().toString(),
"custom-metadata-location").toString();
+ sql(
+ "CREATE VIEW %s TBLPROPERTIES ('%s'='%s') AS SELECT * FROM %s",
+ viewName, "location", customMetadataLocation, tableName);
+ String location = viewCatalog().loadView(TableIdentifier.of(NAMESPACE,
viewName)).location();
+
+ assertThat(sql("DESCRIBE EXTENDED %s", viewName))
+ .contains(
+ row(
+ "View Properties",
+ String.format(
+ "['format-version' = '1', 'location' = '%s', 'provider' =
'iceberg']",
+ customMetadataLocation),
+ ""));
Review Comment:
Agree, let me update this test along with Spark 3.5 test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
