nastra commented on code in PR #14136:
URL: https://github.com/apache/iceberg/pull/14136#discussion_r2388382498
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -50,6 +49,29 @@ public class AzureProperties implements Serializable {
public static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
public static final String ADLS_TOKEN = "adls.token";
+ /**
+ * Configure the Azure token credential provider used to get {@link
TokenCredential}. A fully
+ * qualified concrete class with package that implements the {@link
AdlsTokenCredentialProvider}
+ * interface is required.
+ *
+ * <p>The implementation class must have a no-arg constructor and will be
initialized by calling
+ * the {@link AdlsTokenCredentialProvider#initialize(Map)} method with the
catalog properties.
+ *
+ * <p>Example:
adls.token-credential-provider=com.example.MyCustomTokenCredentialProvider
+ *
+ * <p>When set, the {@link AdlsTokenCredentialProviders#from(Map)} method
will use this provider
+ * to get Azure credentials instead of using the default.
Review Comment:
```suggestion
* to get ADLS credentials instead of using the default.
```
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -50,6 +49,29 @@ public class AzureProperties implements Serializable {
public static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
public static final String ADLS_TOKEN = "adls.token";
+ /**
+ * Configure the Azure token credential provider used to get {@link
TokenCredential}. A fully
Review Comment:
```suggestion
* Configure the ADLS token credential provider used to get {@link
TokenCredential}. A fully
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
