aiborodin commented on PR #14092: URL: https://github.com/apache/iceberg/pull/14092#issuecomment-3344861698
> IMHO the solution you implemented goes beyond the scope of fixing the issue. I'm open to refactoring the aggregator / committer code, but I think we should add a set of minimal changes to fix the correctness issue, along side with increased test coverage. @mxm I do understand the simplicity of https://github.com/apache/iceberg/pull/14182, and I am okay with merging it as a first step. Although I think we should follow up and merge this PR to aim for clean and maintainable code in the long term. We should draw a clear boundary between aggregating temporary WriteResults (`DynamicWriteResultAggregator`) and committing them to a table (`DynamicCommitter`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
