RussellSpitzer commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2384318600
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -1132,6 +1144,46 @@ private TripleIterator<?>
firstNonNullColumn(List<TripleIterator<?>> columns) {
}
}
+ private static class StructLikeReader<T extends StructLike> extends
StructReader<T, T> {
+ private final Types.StructType struct;
+ private final DynConstructors.Ctor<T> ctor;
+
+ StructLikeReader(
+ List<ParquetValueReader<?>> readers, Types.StructType struct, Class<T>
structLikeClass) {
+ super(readers);
+ this.struct = struct;
+ this.ctor =
Review Comment:
I think you may be misreading the code for DynConstructors, if it fails to
find a constructor it will fail see
```
@SuppressWarnings("unchecked")
public <C> Ctor<C> build() {
if (ctor != null) {
return (Ctor<C>) ctor;
}
throw buildRuntimeException(baseClass, problems);
}
```
I also think this is pretty deep in the code and if we do have an exception
here a user probably won't be able to fix.
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -1132,6 +1144,46 @@ private TripleIterator<?>
firstNonNullColumn(List<TripleIterator<?>> columns) {
}
}
+ private static class StructLikeReader<T extends StructLike> extends
StructReader<T, T> {
+ private final Types.StructType struct;
+ private final DynConstructors.Ctor<T> ctor;
+
+ StructLikeReader(
+ List<ParquetValueReader<?>> readers, Types.StructType struct, Class<T>
structLikeClass) {
+ super(readers);
+ this.struct = struct;
+ this.ctor =
Review Comment:
I think you may be misreading the code for DynConstructors, if it fails to
find a constructor it will fail see
```
@SuppressWarnings("unchecked")
public <C> Ctor<C> build() {
if (ctor != null) {
return (Ctor<C>) ctor;
}
throw buildRuntimeException(baseClass, problems);
}
```
I also think this is pretty deep in the code and if we do have an exception
here a user probably won't be able to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
