kevinjqliu commented on code in PR #2515:
URL: https://github.com/apache/iceberg-python/pull/2515#discussion_r2380733281
##########
tests/io/test_pyarrow.py:
##########
@@ -2188,6 +2188,36 @@ def test_stats_aggregator_update_max(vals: List[Any],
primitive_type: PrimitiveT
assert stats.current_max == expected_result
[email protected](
Review Comment:
nit: this would be easier to read if we split into 2 tests, one for success,
another for failure. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
