alessandro-nori commented on code in PR #577: URL: https://github.com/apache/iceberg-go/pull/577#discussion_r2379668507
########## table/statistics.go: ########## @@ -0,0 +1,59 @@ +package table + +import ( + "encoding/json" + "fmt" +) + +type BlobType string Review Comment: Should I also add docstring for public fields or the type are enough? ########## table/statistics.go: ########## @@ -0,0 +1,59 @@ +package table + +import ( + "encoding/json" + "fmt" +) + +type BlobType string Review Comment: Should I also add docstring for public fields or the types are enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
