gabeiglio commented on code in PR #2371:
URL: https://github.com/apache/iceberg-python/pull/2371#discussion_r2377189344
##########
tests/integration/test_catalog.py:
##########
@@ -218,6 +224,146 @@ def test_table_exists(test_catalog: Catalog,
table_schema_nested: Schema, databa
assert test_catalog.table_exists((database_name, table_name)) is True
[email protected]
[email protected]("test_catalog", CATALOGS)
+def test_update_table_transaction(test_catalog: Catalog, test_schema: Schema,
table_name: str, database_name: str) -> None:
+ identifier = (database_name, table_name)
+
+ test_catalog.create_namespace(database_name)
+ table = test_catalog.create_table(identifier, test_schema)
+ assert test_catalog.table_exists(identifier)
+
+ expected_schema = Schema(
+ NestedField(1, "VendorID", IntegerType(), False),
+ NestedField(2, "tpep_pickup_datetime", TimestampType(), False),
+ NestedField(3, "new_col", IntegerType(), False),
+ )
+
+ expected_spec = PartitionSpec(PartitionField(3, 1000, IdentityTransform(),
"new_col"))
+
+ with table.transaction() as transaction:
+ with transaction.update_schema() as update_schema:
Review Comment:
PyIceberg
[docs](https://py.iceberg.apache.org/api/#create-a-table:~:text=with%20field%2DIDs.-,with,-catalog.create_table_transaction)
and impl encourage the usage of context managers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
