wgtmac commented on code in PR #237:
URL: https://github.com/apache/iceberg-cpp/pull/237#discussion_r2375221124


##########
.github/workflows/docs.yml:
##########
@@ -52,14 +52,10 @@ jobs:
           echo "Copying site contents to /tmp/site"
           mv ./site /tmp/site/
 
-      - name: Push changes to gh-pages branch
-        run: |
-          git checkout --orphan gh-pages-tmp
-          git rm --quiet -rf .
-          cp -r /tmp/site/* .
-          git config --global user.name 'GitHub Actions'
-          git config --global user.email '[email protected]'
-          echo "cpp.iceberg.apache.org" > CNAME
-          git add --all
-          git commit -m 'Publish C++ docs'
-          git push -f origin gh-pages-tmp:gh-pages || true
+      - name: Deploy to gh-pages
+        uses: peaceiris/[email protected]
+        if: github.event_name == 'pull_request'
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          publish_dir: ./mkdocs/site
+          publish_branch: gh-pages

Review Comment:
   @Fokko Do we need to manually create `gh-pages` branch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to