smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2372720538
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -70,14 +78,28 @@ private TransientEncryptionState(KeyManagementClient
kmsClient) {
*/
public StandardEncryptionManager(
String tableKeyId, int dataKeyLength, KeyManagementClient kmsClient) {
+ this(List.of(), tableKeyId, dataKeyLength, kmsClient);
+ }
+
+ /**
+ * @param keys a list of existing {@link EncryptedKey}s for this {@link
EncryptionManager} to use
+ * @param tableKeyId table encryption key id
+ * @param dataKeyLength length of data encryption key (16/24/32 bytes)
+ * @param kmsClient Client of KMS used to wrap/unwrap keys in envelope
encryption
+ */
+ public StandardEncryptionManager(
Review Comment:
Could deprecate the old constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
