HuaHuaY commented on code in PR #206:
URL: https://github.com/apache/iceberg-cpp/pull/206#discussion_r2371397656
##########
src/iceberg/expression/literal.h:
##########
@@ -71,6 +74,11 @@ class ICEBERG_EXPORT Literal {
static Literal Double(double value);
static Literal String(std::string value);
static Literal Binary(std::vector<uint8_t> value);
+ static Literal Fixed(std::vector<uint8_t> value);
+
+ /// \brief Factory methods for decimal type
+ static Literal Decimal(const Decimal& value, int32_t precision, int32_t
scale);
Review Comment:
Yes. Only reserve `Decimal(Decimal value, int32_t precision, int32_t scale)`
and define `Value` like this:
```cpp
using Value = std::variant<...,
Decimal, // for decimal
...>;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
