HeartLinked commented on code in PR #236: URL: https://github.com/apache/iceberg-cpp/pull/236#discussion_r2371074683
########## LICENSE: ########## @@ -316,3 +316,59 @@ freely, subject to the following restrictions: Jean-loup Gailly Mark Adler [email protected] [email protected] + +-------------------------------------------------------------------------------- + +3rdparty dependency cpr is statically linked in certain binary Review Comment: > @jbonofre Could you help review LICENSE and NOTICE files for adding `cpr` and `curl`? BTW, do we need to add `OpenSSL` which is an indirect dependency (required by curl)? I have split the task of modifying the license into a separate PR #243 . @jbonofre Could you help review it? In this case, the current PR will not involve license modifications and should be able to be merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
