zeroshade commented on code in PR #575:
URL: https://github.com/apache/iceberg-go/pull/575#discussion_r2370385992
##########
table/metadata.go:
##########
@@ -1313,6 +1366,14 @@ func (c *commonMetadata) validate() error {
c.constructRefs()
+ if err := c.checkMainRefMatchesCurrentSnapshot(); err != nil {
+ return err
+ }
Review Comment:
According to that image, the `current-snapshot-id` is optional, so we
shouldn't error if it's nil and the main branch exists. We should just assume
that the `main` branch is the current snapshot if this isn't set, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
