twuebi commented on code in PR #14151:
URL: https://github.com/apache/iceberg/pull/14151#discussion_r2370048419
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1616,7 +1610,7 @@ && changes(MetadataUpdate.AddSchema.class)
return newSchemaId;
}
- this.lastColumnId = newLastColumnId;
+ this.lastColumnId = Math.max(newLastColumnId, this.lastColumnId);
Review Comment:
Yeah, not sure about the approach tho, changing the API surface is a
breaking change, the alternative would be to silently ignore the parameter,
both doesn't sound very nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
