Fokko commented on code in PR #2491:
URL: https://github.com/apache/iceberg-python/pull/2491#discussion_r2368714432
##########
tests/integration/test_add_files.py:
##########
@@ -503,7 +503,7 @@ def
test_add_files_to_partitioned_table_fails_with_lower_and_upper_mismatch(
@pytest.mark.integration
def test_add_files_snapshot_properties(spark: SparkSession, session_catalog:
Catalog, format_version: int) -> None:
- identifier = f"default.unpartitioned_table_v{format_version}"
+ identifier = f"default.snapshot_properties_v{format_version}"
Review Comment:
I actually prefer to use the test-name in the table name:
```suggestion
identifier = f"default.
test_add_files_snapshot_properties_v{format_version}"
```
This way we can relate the two 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
