fvaleye commented on PR #1602: URL: https://github.com/apache/iceberg-rust/pull/1602#issuecomment-3317902631
> Hi, @fvaleye is this pr ready for review or you still need some effort to improve it? Hi @liurenjie1024 👋, I removed the DataFusion integration and its extra node, so it's ready for review. I tried to use `RecordBatchProjector` (from [this](https://github.com/apache/iceberg-rust/pull/1602#discussion_r2321239980)), but it doesn't meet our requirements for DataFusion (it uses `PARQUET_FIELD_META_KEY`). So, yes, it's ready for review. However, it might require additional refactoring if we want to make these utility functions more general. Please tell me what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
