pvary commented on code in PR #14149:
URL: https://github.com/apache/iceberg/pull/14149#discussion_r2366985144
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DataFileRewriteRunner.java:
##########
@@ -108,8 +112,10 @@ public void processElement(PlannedGroup value, Context
ctx, Collector<ExecutedGr
value.group().rewrittenFiles().size());
}
- try (TaskWriter<RowData> writer = writerFor(value)) {
- try (DataIterator<RowData> iterator = readerFor(value)) {
+ boolean preserveRowId = TableUtil.supportsRowLineage(value.table());
Review Comment:
If we think that the `preserveRowId` is not changing during the lifecycle of
the job (no concurrent V3 migration), we can get this as a constructor
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
