aihuaxu commented on code in PR #13195:
URL: https://github.com/apache/iceberg/pull/13195#discussion_r2366371565
##########
core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithExtract.java:
##########
@@ -683,4 +690,375 @@ public void testIntegerNotIn() {
.as("Should read: id above upper bound (85 > 79, 86 > 79)")
.isTrue();
}
+
+ private static Stream<Arguments> timestampEqParameters() {
Review Comment:
Thanks for the quick update.
Can you add the test cases if the value is min or max, they should be read,
similar to what testIntegerEq() does to test out the border cases?
Also, I'm wondering if we can further paramaterize to combine
testTimestampEq()/testTimestampNanoEq()/testDateEq() that we can have
parameters include: testType, lowerBound, upperBound, literalType,
literalValue, expected. With that, we can further simplify the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
