pvary commented on code in PR #13963: URL: https://github.com/apache/iceberg/pull/13963#discussion_r2343882212
########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java: ########## @@ -37,17 +39,21 @@ class DynamicRecordProcessor<T> extends ProcessFunction<T, DynamicRecordInternal @VisibleForTesting static final String DYNAMIC_TABLE_UPDATE_STREAM = "dynamic-table-update-stream"; Review Comment: Unrelated, but this is also not just visible because of the testing. Also might be better in DynamicIcebergSink, as it is reused there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
