smaheshwar-pltr commented on code in PR #2461:
URL: https://github.com/apache/iceberg-python/pull/2461#discussion_r2341291558
##########
pyiceberg/io/fsspec.py:
##########
@@ -207,7 +207,7 @@ def _adls(properties: Properties) -> AbstractFileSystem:
from azure.core.credentials_async import AsyncTokenCredential
for key, sas_token in {
- key.replace(f"{ADLS_SAS_TOKEN}.", ""): value for key, value in
properties.items() if key.startswith(ADLS_SAS_TOKEN)
+ key.replace(f"{ADLS_SAS_TOKEN}.", ""): value for key, value in
properties.items() if key.startswith(f"{ADLS_SAS_TOKEN}.")
Review Comment:
This looks like the fix for the bug 👍, the Java side gets the props like
[this](https://github.com/apache/iceberg/blob/d1771207c9040f1c8b6886665b56d1a972fe402a/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L76)
with the `ADLS_SAS_TOKEN_PREFIX` including the `.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
