HeartLinked commented on code in PR #236: URL: https://github.com/apache/iceberg-cpp/pull/236#discussion_r2358421459
########## cmake_modules/IcebergThirdpartyToolchain.cmake: ########## @@ -430,6 +430,196 @@ function(resolve_zlib_dependency) endfunction() +# ---------------------------------------------------------------------- +# CURL (for cpr) + +function(resolve_curl_dependency) + prepare_fetchcontent() + + set(BUILD_CURL_EXE + OFF + CACHE BOOL "" FORCE) + set(BUILD_TESTING + OFF + CACHE BOOL "" FORCE) + set(CURL_ENABLE_EXPORT_TARGET + OFF + CACHE BOOL "" FORCE) + set(BUILD_SHARED_LIBS + OFF + CACHE BOOL "" FORCE) + set(CURL_STATICLIB + ON + CACHE BOOL "" FORCE) + set(HTTP_ONLY + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_LDAP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_LDAPS + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_RTSP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_FTP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_FILE + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_TELNET + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_DICT + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_TFTP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_GOPHER + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_POP3 + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_IMAP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_SMTP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_SMB + ON + CACHE BOOL "" FORCE) + set(CURL_CA_BUNDLE + "auto" + CACHE STRING "" FORCE) + set(USE_LIBIDN2 + OFF + CACHE BOOL "" FORCE) + + fetchcontent_declare(CURL Review Comment: We use `FetchContent_Declare` with `FIND_PACKAGE_ARGS` to ensure that if a suitable version of the dependency is already installed on the system, it will be used; otherwise, FetchContent will download it as a fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
