amogh-jahagirdar commented on code in PR #14027:
URL: https://github.com/apache/iceberg/pull/14027#discussion_r2341200100
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -988,6 +995,18 @@ public void testTransformFilter() {
.isTrue();
}
+ @TestTemplate
+ public void testUUIDClassCastExceptionBug() {
Review Comment:
I think this should be called `testUUIDEq` for consistency with the other
test names in this class
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java:
##########
@@ -1267,6 +1274,20 @@ public void testTransformFilter() {
.isTrue();
}
+ @TestTemplate
+ public void testUUIDDictionaryFilter() {
+ boolean shouldReadExisting =
+ new ParquetDictionaryRowGroupFilter(SCHEMA, equal("uuid_col",
TARGET_UUID))
+ .shouldRead(parquetSchema, rowGroupMetadata, dictionaryStore);
+ assertThat(shouldReadExisting).as("Should not crash on UUID
filtering").isTrue();
Review Comment:
Can we have a better failure message than "Should not crash on UUID
filtering"? For consistency with the other tests "Should read: Dictionary
contains a matching entry", similar to below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
