liurenjie1024 commented on PR #1657:
URL: https://github.com/apache/iceberg-rust/pull/1657#issuecomment-3306441725
> Hi @liurenjie1024 , do you mean that we should also include `TaskWriter`
and have `TaskWriter` to split batches by partition? This draft mainly focuses
on refactoring the existing layers and have RollingWriter to become the
top-level writer as of now, and I haven't incoporated this with an actual
partitioning writer or task writer yet. Or do you think it's better to have
everything in one draft?
Hi, @CTTY I'm not saying we should include `TaskWriter`. Per our discussion,
we should have following dependency:
```
PartitionedWriter
|
DataFileWriter(EqDeleateWriter, PositionDeleteWriter) -> This layer is
IcebergWriter
|
RollingFileWriter
|
FileWriter(Parquet, ORC) -> This layer is file format writer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
