aiborodin commented on code in PR #14092:
URL: https://github.com/apache/iceberg/pull/14092#discussion_r2357960716
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -632,4 +633,72 @@ public String toString() {
.add("content_size_in_bytes", contentSizeInBytes == null ? "null" :
contentSizeInBytes)
.toString();
}
+
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ @Override
+ public boolean equals(Object other) {
+ if (other == null || getClass() != other.getClass()) {
+ return false;
+ }
+ BaseFile<?> baseFile = (BaseFile<?>) other;
+ return partitionSpecId == baseFile.partitionSpecId
+ && fileSizeInBytes == baseFile.fileSizeInBytes
+ && Objects.equals(partitionType, baseFile.partitionType)
+ && Objects.equals(fileOrdinal, baseFile.fileOrdinal)
+ && Objects.equals(manifestLocation, baseFile.manifestLocation)
+ && content == baseFile.content
+ && Objects.equals(filePath, baseFile.filePath)
+ && format == baseFile.format
+ && Objects.equals(partitionData, baseFile.partitionData)
+ && Objects.equals(recordCount, baseFile.recordCount)
+ && Objects.equals(dataSequenceNumber, baseFile.dataSequenceNumber)
+ && Objects.equals(fileSequenceNumber, baseFile.fileSequenceNumber)
+ && Objects.equals(columnSizes, baseFile.columnSizes)
+ && Objects.equals(valueCounts, baseFile.valueCounts)
+ && Objects.equals(nullValueCounts, baseFile.nullValueCounts)
+ && Objects.equals(nanValueCounts, baseFile.nanValueCounts)
+ && Objects.equals(lowerBounds, baseFile.lowerBounds)
+ && Objects.equals(upperBounds, baseFile.upperBounds)
+ && Objects.deepEquals(splitOffsets, baseFile.splitOffsets)
+ && Objects.deepEquals(equalityIds, baseFile.equalityIds)
+ && Objects.deepEquals(keyMetadata, baseFile.keyMetadata)
+ && Objects.equals(sortOrderId, baseFile.sortOrderId)
+ && Objects.equals(firstRowId, baseFile.firstRowId)
+ && Objects.equals(referencedDataFile, baseFile.referencedDataFile)
+ && Objects.equals(contentOffset, baseFile.contentOffset)
+ && Objects.equals(contentSizeInBytes, baseFile.contentSizeInBytes)
+ && Objects.equals(avroSchema, baseFile.avroSchema);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(
+ partitionType,
+ fileOrdinal,
+ manifestLocation,
+ partitionSpecId,
+ content,
+ filePath,
+ format,
+ partitionData,
+ recordCount,
+ fileSizeInBytes,
+ dataSequenceNumber,
+ fileSequenceNumber,
+ columnSizes,
+ valueCounts,
+ nullValueCounts,
+ nanValueCounts,
+ lowerBounds,
+ upperBounds,
+ Arrays.hashCode(splitOffsets),
+ Arrays.hashCode(equalityIds),
+ Arrays.hashCode(keyMetadata),
+ sortOrderId,
+ firstRowId,
+ referencedDataFile,
+ contentOffset,
+ contentSizeInBytes,
+ avroSchema);
+ }
Review Comment:
As I replied in my previous comment, they are not strictly necessary;
however, they simplify the testing code. It also seems reasonable in general to
have these default implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
