lliangyu-lin commented on code in PR #1621:
URL: https://github.com/apache/iceberg-rust/pull/1621#discussion_r2356876727
##########
crates/sqllogictest/Cargo.toml:
##########
@@ -31,8 +31,27 @@ datafusion = { workspace = true }
datafusion-sqllogictest = { workspace = true }
enum-ordinalize = { workspace = true }
indicatif = { workspace = true }
+iceberg = { workspace = true }
+iceberg_test_utils = { path = "../test_utils", features = ["tests"] }
+iceberg-catalog-rest = { workspace = true }
+iceberg-datafusion = { workspace = true }
sqllogictest = { workspace = true }
toml = { workspace = true }
+tokio = { workspace = true }
+env_logger = "0.11.8"
+log = "0.4.25"
+itertools = "0.13.0"
+spark-connect-rs = { git = "https://github.com/apache/spark-connect-rust.git";,
rev = "061cb3ecb187b039141f20c722c7984e915f3b9d" }
+#spark-connect-rs = "0.0.2"
Review Comment:
Sorry for the late response. Have been busy with other works.
The issue I'm concerned here is that with using direct git url, to build the
crate will now require to build spark-connect-rs first, which requires cmake
and protobuf installed.
https://github.com/sjrusso8/spark-connect-rs/blob/main/README.md?plain=1#L52
That's the main reason why I excluded to build this in
[Makefile](https://github.com/apache/iceberg-rust/pull/1621/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R23)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
