kevinjqliu opened a new issue, #1667: URL: https://github.com/apache/iceberg-rust/issues/1667
### Apache Iceberg Rust version None ### Describe the bug Context: MSRV check is currently only done in CI https://github.com/apache/iceberg-rust/blob/66ba909b35fb2ce413112c0936a4b3a93677f152/.github/workflows/ci.yml#L164-L173 This would require multiple roundtrips and checking against CI, which is costly. I propose that we add a new Makefile command to run this MSRV check. ``` check-msrv: cargo generate-lockfile -Z direct-minimal-versions cargo check --locked --workspace ``` We have to ensure the use of the MSRV version from Cargo.toml's `rust-version` field here somehow... https://github.com/apache/iceberg-rust/blob/66ba909b35fb2ce413112c0936a4b3a93677f152/Cargo.toml#L39 The check itself, mainly the `cargo generate-lockfile` command, also generates a new `Cargo.lock` file which should not be checked in. This can be a potential footgun when upgrading libraries, as we've seen in #1501. Perhaps in the make command, we can also restore any Cargo.lock file changes to prevent footgun. ### To Reproduce _No response_ ### Expected behavior _No response_ ### Willingness to contribute None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
