Fokko commented on code in PR #2432: URL: https://github.com/apache/iceberg-python/pull/2432#discussion_r2353406023
########## pyiceberg/io/pyarrow.py: ########## @@ -201,6 +201,8 @@ ICEBERG_SCHEMA = b"iceberg.schema" # The PARQUET: in front means that it is Parquet specific, in this case the field_id PYARROW_PARQUET_FIELD_ID_KEY = b"PARQUET:field_id" +# ORC field ID key for Iceberg field IDs in ORC metadata +ORC_FIELD_ID_KEY = b"iceberg.id" Review Comment: This is in line with the Java impl, should we also set the required attribute? https://github.com/apache/iceberg/blob/ee90c10e39cec0ccceb9425e03a3e0b5690daf3b/orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java#L69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
