DerGut commented on code in PR #1670:
URL: https://github.com/apache/iceberg-rust/pull/1670#discussion_r2354952126
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -225,7 +225,7 @@ impl Display for NamespaceIdent {
}
/// TableIdent represents the identifier of a table in the catalog.
-#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, Hash)]
+#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, PartialOrd,
Hash)]
Review Comment:
[`NamespaceIdent`](https://github.com/apache/iceberg-rust/blob/e7db4374e4df983bd63a617380ae215d66f271c2/crates/iceberg/src/catalog/mod.rs#L130)
does 👍
Given there's no pushback to adding ordering in general, I agree that `Ord`
represents it more accurately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
