zeroshade commented on code in PR #560:
URL: https://github.com/apache/iceberg-go/pull/560#discussion_r2353561865
##########
manifest.go:
##########
@@ -849,6 +850,14 @@ func (v2writerImpl) prepareEntry(entry *manifestEntry,
snapshotID int64) (Manife
return entry, nil
}
+type v3writerImpl struct{}
+
+func (v3writerImpl) content() ManifestContent { return ManifestContentData }
+func (v3writerImpl) prepareEntry(entry *manifestEntry, snapshotID int64)
(ManifestEntry, error) {
+ // TODO : implement this for v3
+ return entry, nil
Review Comment:
return a not-implemented-error for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
