ebyhr commented on code in PR #14065:
URL: https://github.com/apache/iceberg/pull/14065#discussion_r2350380536
##########
docs/docs/configuration.md:
##########
@@ -143,6 +143,23 @@ The properties can be manually constructed or passed in
from a compute engine li
Spark uses its session properties as catalog properties, see more details in
the [Spark configuration](spark-configuration.md#catalog-configuration) section.
Flink passes in catalog properties through `CREATE CATALOG` statement, see
more details in the [Flink](flink.md#adding-catalogs) section.
+### Catalog REST auth properties
+
+The following catalog properties configure authentication for the REST catalog.
+They support Basic, OAuth2, and SigV4 authentication, in addition to the
default none.
+
+| Property | Default | Description
|
+| --------------------------------- | ------------------ |
------------------------------------------------------ |
+| rest.auth.type | none | Authentication
mechanism for REST catalog access. Supported values: `none`, `basic`, `oauth2`,
`sigv4`. |
Review Comment:
`google` type also exists.
https://github.com/apache/iceberg/blob/754679ddccdf81a97dc65d40f1a2a6fb9f6ee9b0/core/src/main/java/org/apache/iceberg/rest/auth/AuthProperties.java#L31
##########
docs/docs/configuration.md:
##########
@@ -143,6 +143,23 @@ The properties can be manually constructed or passed in
from a compute engine li
Spark uses its session properties as catalog properties, see more details in
the [Spark configuration](spark-configuration.md#catalog-configuration) section.
Flink passes in catalog properties through `CREATE CATALOG` statement, see
more details in the [Flink](flink.md#adding-catalogs) section.
+### Catalog REST auth properties
+
+The following catalog properties configure authentication for the REST catalog.
+They support Basic, OAuth2, and SigV4 authentication, in addition to the
default none.
+
+| Property | Default | Description
|
+| --------------------------------- | ------------------ |
------------------------------------------------------ |
+| rest.auth.type | none | Authentication
mechanism for REST catalog access. Supported values: `none`, `basic`, `oauth2`,
`sigv4`. |
+| rest.auth.basic.username | null | Username for Basic
authentication. Required if `rest.auth.type` = `basic`. |
+| rest.auth.basic.password | null | Password for Basic
authentication. Required if `rest.auth.type` is `basic`. |
Review Comment:
How about extracting tables for each auth type?
##########
docs/docs/configuration.md:
##########
@@ -143,6 +143,23 @@ The properties can be manually constructed or passed in
from a compute engine li
Spark uses its session properties as catalog properties, see more details in
the [Spark configuration](spark-configuration.md#catalog-configuration) section.
Flink passes in catalog properties through `CREATE CATALOG` statement, see
more details in the [Flink](flink.md#adding-catalogs) section.
+### Catalog REST auth properties
+
+The following catalog properties configure authentication for the REST catalog.
+They support Basic, OAuth2, and SigV4 authentication, in addition to the
default none.
Review Comment:
Let's add `Google` authentication.
https://github.com/apache/iceberg/pull/13564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
