kevinjqliu commented on code in PR #14066:
URL: https://github.com/apache/iceberg/pull/14066#discussion_r2349686391
##########
site/README.md:
##########
@@ -145,9 +145,12 @@ Deploying the docs is a two-step process:
```sh
make release ICEBERG_VERSION=${ICEBERG_VERSION}
```
- 1. Build and push the generated site to `asf-site`.
+ 1. Build and push the generated site to the `asf-site` branch of [remote
repo](https://github.com/apache/iceberg). This requires committer write
permission.
```sh
- make deploy
+ # Default remote name is 'apache'
+ make deploy
+ # Or specify a different remote
+ make deploy remote_name=apache
Review Comment:
https://www.mkdocs.org/user-guide/configuration/#remote_name
otherwise, the origin name is default to `origin`
I use to have the apache/iceberg repo as `origin`, but now its `apache`.
This change makes it configurable 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]