ludlows commented on code in PR #14072:
URL: https://github.com/apache/iceberg/pull/14072#discussion_r2348870768
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -400,6 +400,12 @@ Builder checkConflicts(boolean check) {
private void checkAndAddPartitionName(String name, Integer sourceColumnId)
{
Types.NestedField schemaField =
this.caseSensitive ? schema.findField(name) :
schema.caseInsensitiveFindField(name);
+ // corner case: extra partition column in metadata table and whose field
id is extremely large
+ if (null != schemaField
+ && schemaField.name().equals("partition")
+ && schemaField.fieldId() > 2000) {
Review Comment:
@huaxingao thanks for the comment. it seems the problem caused by the
special column name `partition`, so I have to hard-code the `partition` here.
here I double the start id of partition ( `1000`) and set it to 2000. let me
find another way without hard-coding the threshold value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
