stubz151 commented on code in PR #13997: URL: https://github.com/apache/iceberg/pull/13997#discussion_r2344662817
########## api/src/main/java/org/apache/iceberg/io/FileRange.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.io; + +import java.nio.ByteBuffer; +import java.util.concurrent.CompletableFuture; + +public class FileRange { + private final CompletableFuture<ByteBuffer> byteBuffer; + private final long offset; + private final int length; + + public FileRange(CompletableFuture<ByteBuffer> byteBuffer, long offset, int length) { Review Comment: We not passing the bytebuffer in here right, we passing a future that completes with a byte buffer, we need a way to map the futures in Iceberg to the future's we are setting in Parquet, So when we call `parquetFileRange.setDataReadFuture(future);` we need to have a way of tracking that future in Iceberg and that's what this gives us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
