RussellSpitzer commented on code in PR #14064:
URL: https://github.com/apache/iceberg/pull/14064#discussion_r2345071490
##########
core/src/main/java/org/apache/iceberg/ManifestListWriter.java:
##########
@@ -100,6 +100,10 @@ protected ManifestFile prepare(ManifestFile manifest) {
if (manifest.content() != ManifestContent.DATA || manifest.firstRowId()
!= null) {
return wrapper.wrap(manifest, null);
} else {
+ Preconditions.checkState(
+ manifest.existingRowsCount() != null &&
manifest.addedRowsCount() != null,
+ "Cannot include v1 manifest with missing existing or added
rows count to a Table with row lineage enabled. Manifest path: %s",
Review Comment:
another nit here, we are assuming it is a V1 manifest here, but it could
just be a broken manifest too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
