RussellSpitzer commented on PR #13976: URL: https://github.com/apache/iceberg/pull/13976#issuecomment-3285689560
> > Here we check that root allocator has no unallocated memory left after each test case. I'm not sure that this actually covers child allocators too, I suppose it does (though it is easy to add a verification for child allocators here, if it doesn't). What do you thing? We can't actually do that for another reason, it will break parallel test runs since multiple tests could be using the root allocator so we can legitimately have allocators open after a test. I think your original intuition that we need to not use the root allocator directly for these special columns is probably right. We need to refactor such that no one touches an allocator they don't have access to for closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
