wgtmac commented on code in PR #209:
URL: https://github.com/apache/iceberg-cpp/pull/209#discussion_r2342896140
##########
.github/workflows/test.yml:
##########
@@ -80,10 +80,10 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
with:
fetch-depth: 0
- - name: Install ZLIB
+ - name: Install dependencies
shell: cmd
run: |
- vcpkg install zlib:x64-windows
+ vcpkg install zlib:x64-windows nlohmann-json:x64-windows
nanoarrow:x64-windows
Review Comment:
Can you try to add `spdlog` as well?
##########
src/iceberg/CMakeLists.txt:
##########
@@ -72,13 +72,13 @@ list(APPEND
ZLIB::ZLIB)
list(APPEND
ICEBERG_STATIC_INSTALL_INTERFACE_LIBS
- "Iceberg::nanoarrow_static"
- "Iceberg::nlohmann_json"
+
"$<IF:$<BOOL:${NANOARROW_VENDORED}>,Iceberg::nanoarrow_static,$<IF:$<TARGET_EXISTS:nanoarrow::nanoarrow_static>,nanoarrow::nanoarrow_static,nanoarrow::nanoarrow_shared>>"
+
"$<IF:$<BOOL:${NLOHMANN_JSON_VENDORED}>,Iceberg::nlohmann_json,$<IF:$<TARGET_EXISTS:nlohmann_json::nlohmann_json>,nlohmann_json::nlohmann_json,nlohmann_json::nlohmann_json>>"
"$<IF:$<BOOL:${SPDLOG_VENDORED}>,Iceberg::spdlog,spdlog::spdlog>")
Review Comment:
I guess we don't need to change this for spdlog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
