dongxiao1198 commented on code in PR #216:
URL: https://github.com/apache/iceberg-cpp/pull/216#discussion_r2342716492
##########
src/iceberg/manifest_adapter.h:
##########
@@ -33,34 +40,100 @@ class ICEBERG_EXPORT ManifestAdapter {
public:
ManifestAdapter() = default;
virtual ~ManifestAdapter() = default;
+ virtual Status Init() = 0;
- virtual Status StartAppending() = 0;
- virtual Result<ArrowArray> FinishAppending() = 0;
+ Status StartAppending();
+ Result<ArrowArray> FinishAppending();
int64_t size() const { return size_; }
+ virtual std::shared_ptr<Schema> schema() const = 0;
+
+ protected:
+ Status AppendField(ArrowArray* arrowArray, int64_t value);
+ Status AppendField(ArrowArray* arrowArray, uint64_t value);
Review Comment:
Yes those func should be defined in static, already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
