dttung2905 commented on code in PR #13268:
URL: https://github.com/apache/iceberg/pull/13268#discussion_r2338001282
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -86,6 +86,19 @@ public class IcebergSinkConfig extends AbstractConfig {
private static final String COMMIT_TIMEOUT_MS_PROP =
"iceberg.control.commit.timeout-ms";
private static final int COMMIT_TIMEOUT_MS_DEFAULT = 30_000;
private static final String COMMIT_THREADS_PROP =
"iceberg.control.commit.threads";
+ private static final String COMMIT_MAX_RETRIES_PROP =
"iceberg.control.commit.max-retries";
+ private static final int COMMIT_MAX_RETRIES_DEFAULT = 3;
+ private static final String COMMIT_MIN_RETRY_WAIT_MS_PROP =
+ "iceberg.control.commit.min-retry-wait-ms";
+ private static final int COMMIT_MIN_RETRY_WAIT_MS_DEFAULT = 100;
+ private static final String COMMIT_MAX_RETRY_WAIT_MS_PROP =
+ "iceberg.control.commit.max-retry-wait-ms";
+ private static final int COMMIT_MAX_RETRY_WAIT_MS_DEFAULT = 60_000;
Review Comment:
Sorry I don't get what you mean, are you saying you prefer 5,601,000 over
300,000 ? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
