eric-maynard commented on code in PR #13859:
URL: https://github.com/apache/iceberg/pull/13859#discussion_r2335587090
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java:
##########
@@ -510,8 +527,8 @@ public void testGoldenFiles(
Schema expectedSchema = new Schema(optional(1, "data", primitiveType));
assertIdenticalFileContents(
- new File(goldenFileUrl.toURI()),
Review Comment:
Also, can you clarify the nit? line 524 is:
```
if (plainFileUrl == null) {
```
Line 520 is:
```
assumeThat(goldenFileUrl).isNotNull().as("type/encoding pair exists");
```
These are not meant to do the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
