liurenjie1024 commented on code in PR #1663:
URL: https://github.com/apache/iceberg-rust/pull/1663#discussion_r2332760771
##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -67,6 +67,15 @@ impl DefaultLocationGenerator {
};
Ok(Self { data_location })
}
+
+ /// Create a new `DefaultLocationGenerator` with a specified data location.
+ ///
+ /// # Arguments
+ ///
+ /// * `data_location` - The data location to use for generating file
locations.
+ pub fn new_with_data_location(data_location: String) -> Self {
Review Comment:
```suggestion
pub fn with_data_location(data_location: String) -> Self {
```
nit: This is a little more rusty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
