itamarwe commented on PR #13988: URL: https://github.com/apache/iceberg/pull/13988#issuecomment-3263049791
> > What about logs for operations such as `listNamespaces`, `loadNamespace`, `listTables`... Let's make sure we have full coverage of the operations. > > In my opinion, logging `listNamespaces` or `listTables` at INFO would be redundant, these are background read operations and not actual changes or audit events. I’d suggest keeping INFO logs for mutations like create, update.., and optionally logging listing operations at DEBUG for troubleshooting if needed. > > Also, some operations are already logged by the backing catalogs implementations like `JdbcCatalog`. If we log them again in the REST adapter, we’ll get duplication. Do you still prefer that I add logs for these operations at the handler level as well? > > @kevinjqliu @ebyhr , would appreciate your thoughts :) Personally, I would log each and every request. It's an audit log and if the server processed a request I would like to know. If there are also JDBC logs they are not redundant IMO. I would like to have an audit log to each of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
