huaxingao commented on code in PR #13824:
URL: https://github.com/apache/iceberg/pull/13824#discussion_r2323743714
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -64,11 +64,11 @@
import org.apache.spark.sql.connector.read.streaming.ReadLimit;
import org.apache.spark.sql.connector.read.streaming.ReadMaxFiles;
import org.apache.spark.sql.connector.read.streaming.ReadMaxRows;
-import org.apache.spark.sql.connector.read.streaming.SupportsAdmissionControl;
+import
org.apache.spark.sql.connector.read.streaming.SupportsTriggerAvailableNow;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class SparkMicroBatchStream implements MicroBatchStream,
SupportsAdmissionControl {
+public class SparkMicroBatchStream implements MicroBatchStream,
SupportsTriggerAvailableNow {
Review Comment:
API-compatible (since `SupportsTriggerAvailableNow` extends
`SupportsAdmissionControl`), but this is a user-visible behavior change for
`Trigger.AvailableNow`. Do we need to document this change explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
