wgtmac commented on code in PR #200:
URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2320579815
##########
src/iceberg/table_scan.cc:
##########
@@ -45,6 +43,21 @@ int32_t FileScanTask::files_count() const { return 1; }
int64_t FileScanTask::estimated_row_count() const { return
data_file_->record_count; }
+Result<std::unique_ptr<ArrowArrayReader>> FileScanTask::ToArrowArrayReader(
Review Comment:
We have two libraries, one is `libiceberg` and the other is
`libiceberg-bundle`. For `libiceberg`, it only depends on Arrow C ABI so it
cannot have access to `::arrow::RecordBatch`. An alternative is to use
`ArrowArrayStream` but it requires more work so I'm not sure if it worths the
effort at this moment. Since the API is not stable before 1.0.0, we can change
our mind at any time for any better idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
